[jira] [Created] (VFS-685) Test classes should be public so test suits can be extended

[Otto Fowler (JIRA)]

Otto Fowler created VFS-685:
-------------------------------

Summary: Test classes should be public so test suits can be extended
Key: VFS-685
URL: https://issues.apache.org/jira/browse/VFS-685
Project: Commons VFS
Issue Type: Bug
Reporter: Otto Fowler
Assignee: Otto Fowler


FileInfo and possibly other classes should be public, that way someone can write tests for their providers that extend and are close to the same as the project tests



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[Bernd Eckenfels (JIRA)]

[ https://issues.apache.org/jira/browse/VFS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713202#comment-16713202 ]

Bernd Eckenfels commented on VFS-685:
-------------------------------------

Just a FYI, I have an provider which runs the whole provider testsuite from the main project by ways of depending on the test jar. However it has some problems with resources and the `code.*` classes. And the logic is really really hard to understand at all. [https://github.com/ecki/seeburger-vfs2/blob/master/vfs2provider-jdbctable/src/test/java/com/seeburger/vfs2/provider/jdbctable/test/H2ProviderTestCase.java]

 

Post by Otto Fowler (JIRA)
Test classes should be public so test suits can be extended
-----------------------------------------------------------
Key: VFS-685
URL: https://issues.apache.org/jira/browse/VFS-685
Project: Commons VFS
Issue Type: Bug
Reporter: Otto Fowler
Assignee: Otto Fowler
Priority: Major
FileInfo and possibly other classes should be public, that way someone can write tests for their providers that extend and are close to the same as the project tests

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[Otto Fowler (JIRA)]

[ https://issues.apache.org/jira/browse/VFS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713205#comment-16713205 ]

Otto Fowler commented on VFS-685:
---------------------------------

Understood.

 

I wrote a provider for zookeeper, original in project.  I was going to submit it but I'm going to release it outside the project.  In order to get a FILE_OR_FOLDER type to work with the test cases, I needed to create FileOrFolder versions of a couple of the standard test cases, those classes now in my project and not in the vfs package.  I cannot use these classes that extend the abstract test classes without FileInfo.

Outside provider writers should be able to both run the tests, and add new tests.

 

Post by Otto Fowler (JIRA)
Test classes should be public so test suits can be extended
-----------------------------------------------------------
Key: VFS-685
URL: https://issues.apache.org/jira/browse/VFS-685
Project: Commons VFS
Issue Type: Bug
Reporter: Otto Fowler
Assignee: Otto Fowler
Priority: Major
FileInfo and possibly other classes should be public, that way someone can write tests for their providers that extend and are close to the same as the project tests

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[Gary Gregory (JIRA)]

[ https://issues.apache.org/jira/browse/VFS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713304#comment-16713304 ]

Gary Gregory commented on VFS-685:
----------------------------------

So should this PR still be merged?

If so, the new non-trivial public methods should be Javadoc'd IMO.

Gary

Post by Otto Fowler (JIRA)
Test classes should be public so test suits can be extended
-----------------------------------------------------------
Key: VFS-685
URL: https://issues.apache.org/jira/browse/VFS-685
Project: Commons VFS
Issue Type: Bug
Reporter: Otto Fowler
Assignee: Otto Fowler
Priority: Major
Labels: patch-available
FileInfo and possibly other classes should be public, that way someone can write tests for their providers that extend and are close to the same as the project tests

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[Otto Fowler (JIRA)]

[ https://issues.apache.org/jira/browse/VFS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713329#comment-16713329 ]

Otto Fowler commented on VFS-685:
---------------------------------

Of course it should be.  Not all providers will be submitted, and it is inconsistent to have the ability to extend the classes but not have all the types available. 

 

I'll javadoc them. 

Post by Otto Fowler (JIRA)
Test classes should be public so test suits can be extended
-----------------------------------------------------------
Key: VFS-685
URL: https://issues.apache.org/jira/browse/VFS-685
Project: Commons VFS
Issue Type: Bug
Reporter: Otto Fowler
Assignee: Otto Fowler
Priority: Major
Labels: patch-available
FileInfo and possibly other classes should be public, that way someone can write tests for their providers that extend and are close to the same as the project tests

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[Otto Fowler (JIRA)]

[ https://issues.apache.org/jira/browse/VFS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713330#comment-16713330 ]

Otto Fowler commented on VFS-685:
---------------------------------

What would be great is if we could land this and the other things in review and get a release out.

 

Post by Otto Fowler (JIRA)
Test classes should be public so test suits can be extended
-----------------------------------------------------------
Key: VFS-685
URL: https://issues.apache.org/jira/browse/VFS-685
Project: Commons VFS
Issue Type: Bug
Reporter: Otto Fowler
Assignee: Otto Fowler
Priority: Major
Labels: patch-available
FileInfo and possibly other classes should be public, that way someone can write tests for their providers that extend and are close to the same as the project tests

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[Otto Fowler (JIRA)]

[ https://issues.apache.org/jira/browse/VFS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713385#comment-16713385 ]

Otto Fowler commented on VFS-685:
---------------------------------

If we wanted to say, look at reviewing a couple of in q pr's to fill out the release i would be up for helping with that

Post by Otto Fowler (JIRA)
Test classes should be public so test suits can be extended
-----------------------------------------------------------
Key: VFS-685
URL: https://issues.apache.org/jira/browse/VFS-685
Project: Commons VFS
Issue Type: Bug
Reporter: Otto Fowler
Assignee: Otto Fowler
Priority: Major
Labels: patch-available
FileInfo and possibly other classes should be public, that way someone can write tests for their providers that extend and are close to the same as the project tests

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)